Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua cluster_specifier: fix crash in getCluster() #37073

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ggreenway
Copy link
Contributor

Envoy would crash when the Lua garbage collector ran if getCluster() had been called.

This was added in #36998

Envoy would crash when the Lua garbage collector ran if `getCluster()`
had been called.

This was added in envoyproxy#36998

Signed-off-by: Greg Greenway <ggreenway@apple.com>
Copy link
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@wbpcode wbpcode merged commit 95dcf45 into envoyproxy:main Nov 9, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants